From: Wolfgang Denk Date: Fri, 19 Apr 2013 14:58:36 +0200 Subject: [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK In-Reply-To: <201304191358.25181.marex@denx.de> References: <1366344655-8535-1-git-send-email-marex@denx.de> <1366344655-8535-6-git-send-email-marex@denx.de> <20130419055211.8EB56200566@gemini.denx.de> <201304191358.25181.marex@denx.de> Message-ID: <20130419125836.69EC2200566@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek Vasut, In message <201304191358.25181.marex@denx.de> you wrote: > > > > +#define CONFIG_LOADADDR 0x70800000 > > > +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR > > > > What do we need CONFIG_LOADADDR for? > > For this stuff, the "loadaddr" env variable. I have kinda idea to kill this and > unify it to CONFIG_SYS_LOAD_ADDR all around, what do you think? Why CONFIG_SYS_* ? > include/env_default.h:#ifdef CONFIG_LOADADDR > include/env_default.h: "loadaddr=" __stringify(CONFIG_LOADADDR) "\0" Indeed - I missed this one. I only checked C and asm sources, and cound not find a single reference... So arch/blackfin/include/asm/config.h and include/env_default.h are the only locateions that refer to CONFIG_LOADADDR ? This should indeed be cleaned up. [But this is not related to your patch any longer.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If something is different, it's either better or worse, and usually both. - Larry Wall