Received: from eggs.gnu.org ([208.118.235.92]:33877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUG7c-0003qN-SB for qemu-devel@nongnu.org; Mon, 22 Apr 2013 08:45:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUG7b-0004EL-KA for qemu-devel@nongnu.org; Mon, 22 Apr 2013 08:45:28 -0400 Date: Mon, 22 Apr 2013 14:45:23 +0200 From: Stefan Hajnoczi Message-ID: <20130422124523.GD21317@stefanha-thinkpad.redhat.com> References: <1366355475-7243-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366355475-7243-1-git-send-email-jasowang@redhat.com> Subject: Re: [Qemu-devel] [PATCH] tap: properly initialize vhostfds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: Michal Privoznik , aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org On Fri, Apr 19, 2013 at 03:11:15PM +0800, Jason Wang wrote: > Only tap->vhostfd were checked net_init_tap_one(), but tap->vhostfds were > forgot, this will lead qemu to ignore all fds passed by management through > vhostfds, and tries to create vhost_net device itself. Fix by adding this check > also. > > Reportyed-by: Michal Privoznik > Cc: Michal Privoznik > Cc: qemu-stable@nongnu.org > Signed-off-by: Jason Wang > --- > net/tap.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan