From: Tom Rini Date: Tue, 23 Apr 2013 11:34:06 -0400 Subject: [U-Boot] [PATCH 1/2] net: ks8851_mll: add ethernet support In-Reply-To: <1366712248-17343-2-git-send-email-voice.shen@atmel.com> References: <1366712248-17343-1-git-send-email-voice.shen@atmel.com> <1366712248-17343-2-git-send-email-voice.shen@atmel.com> Message-ID: <20130423153406.GG14952@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Apr 23, 2013 at 06:17:27PM +0800, Bo Shen wrote: > From: Roberto Cerati > > The device interface is 16 bits wide. > All the available packets are read from the incoming fifo. [snip] > +/* union ks_tx_hdr - tx header data > + * @txb: The header as bytes /* * union ks_tx_hdr... Please fix globally. [snip] > +#define RXFSHR_ERR (RXFSHR_RXCE | RXFSHR_RXRF |\ #define please, thanks. Looks fine aside from these style problems however, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: