From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 23 Apr 2013 21:07:21 +0200 Subject: [PATCH v2] usb: phy: don't mark usb_bind_phy as __init In-Reply-To: <20130423171734.GA31432@kroah.com> References: <1366734653-488286-1-git-send-email-arnd@arndb.de> <1366734653-488286-20-git-send-email-arnd@arndb.de> <20130423171734.GA31432@kroah.com> Message-ID: <201304232107.22084.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org It makes no sense for a symbol to be both exported and marked __init, because any users in modules would be calling this function after it gets discarded. Further, this patch revolves a section mismatch warning from usbhs_init_phys(), which is intentionally not marked __init: WARNING: vmlinux.o(.text+0x413f8): Section mismatch in reference from the function usbhs_init_phys() to the function .init.text:usb_bind_phy() Signed-off-by: Arnd Bergmann Cc: Alan Stern Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb at vger.kernel.org --- v2: rebased on linux-next diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index f52c006..a9984c7 100644 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c @@ -413,7 +413,7 @@ EXPORT_SYMBOL_GPL(usb_remove_phy); * * To be used by platform specific initialization code. */ -int __init usb_bind_phy(const char *dev_name, u8 index, +int usb_bind_phy(const char *dev_name, u8 index, const char *phy_dev_name) { struct usb_phy_bind *phy_bind;