Received: from eggs.gnu.org ([208.118.235.92]:41443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUzq8-0006oJ-Tx for qemu-devel@nongnu.org; Wed, 24 Apr 2013 09:34:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUzq7-0003sz-DC for qemu-devel@nongnu.org; Wed, 24 Apr 2013 09:34:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUzq7-0003nI-4s for qemu-devel@nongnu.org; Wed, 24 Apr 2013 09:34:27 -0400 Date: Wed, 24 Apr 2013 15:34:08 +0200 From: Igor Mammedov Message-ID: <20130424153408.641a50c6@nial.usersys.redhat.com> In-Reply-To: <5177CB4D.8040705@suse.de> References: <1366705795-24732-1-git-send-email-imammedo@redhat.com> <1366705795-24732-3-git-send-email-imammedo@redhat.com> <5176AFDA.1050700@suse.de> <5177CB4D.8040705@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/21] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, gleb@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, quintela@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, blauwirbel@gmail.com, anthony.perard@citrix.com, alex.williamson@redhat.com, kraxel@redhat.com, yang.z.zhang@intel.com, pbonzini@redhat.com, stefano.stabellini@eu.citrix.com, armbru@redhat.com, rth@twiddle.net On Wed, 24 Apr 2013 14:08:45 +0200 Andreas F=E4rber wrote: > Am 23.04.2013 17:59, schrieb Andreas F=E4rber: > > Am 23.04.2013 10:29, schrieb Igor Mammedov: > >> ... to synchronize CPU state to KVM > >> > >> Signed-off-by: Igor Mammedov > >> Reviewed-by: Eduardo Habkost > >> --- > >> v2: > >> * linking kvm-stub.o to *-user target moved in separate patch > >=20 > > Thanks, applied to qom-cpu: > > https://github.com/afaerber/qemu-cpu/commits/qom-cpu >=20 > To facilitate conflict resolution for future patches, I have modified > this to match other functions in there and to spare refactorings: >=20 > diff --git a/qom/cpu.c b/qom/cpu.c > index 0c76712..66f7c00 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -58,8 +58,10 @@ static ObjectClass *cpu_common_class_by_name(const > char *cpu_model) >=20 > static void cpu_common_realizefn(DeviceState *dev, Error **errp) > { > + CPUState *cpu =3D CPU(dev); > + > if (dev->hotplugged) { > - cpu_synchronize_post_init(CPU(dev)); > + cpu_synchronize_post_init(cpu); > } > } >=20 Fixed conflicts in 4-5/21, available at https://github.com/imammedo/qemu/commits/cpu_set.WIP > Andreas >=20