From: Wolfgang Denk Date: Thu, 25 Apr 2013 23:42:21 +0200 Subject: [U-Boot] [PATCH V3 2/2] arm: mx5: Add support for DENX M53EVK In-Reply-To: <1366920963-8646-2-git-send-email-marex@denx.de> References: <1366920963-8646-1-git-send-email-marex@denx.de> <1366920963-8646-2-git-send-email-marex@denx.de> Message-ID: <20130425214221.925FC38489C@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek Vasut, In message <1366920963-8646-2-git-send-email-marex@denx.de> you wrote: ... > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -954,6 +954,7 @@ Marek Vasut > mx23_olinuxino i.MX23 > m28evk i.MX28 > sc_sps_1 i.MX28 > + m53evk i.MX53 Please keep this list (and all similar ones) sorted. Thanks. > +#define CONFIG_SYS_SDRAM_BASE (PHYS_SDRAM_1) > +#define CONFIG_SYS_INIT_RAM_ADDR (IRAM_BASE_ADDR) > +#define CONFIG_SYS_INIT_RAM_SIZE (IRAM_SIZE) Are the parens needed / useful here? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Do not underestimate the value of print statements for debugging. Don't have aesthetic convulsions when using them, either.