From: Marek Vasut <marex@denx.de>
Date: Fri, 26 Apr 2013 14:21:46 +0200
Subject: [U-Boot] [PATCH v3 09/11] usb: gadget: add Faraday FOTG210 USB
	gadget support
In-Reply-To: <1366963360-2987-10-git-send-email-dantesu@gmail.com>
References: <1366963360-2987-1-git-send-email-dantesu@gmail.com>
	<1366963360-2987-10-git-send-email-dantesu@gmail.com>
Message-ID: <201304261421.46938.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Kuo-Jung Su,

> From: Kuo-Jung Su <dantesu@faraday-tech.com>
> 
> The Faraday FOTG210 is an OTG chip which could operate
> as either an EHCI Host or a USB Device as a time.
> 
> Signed-off-by: Kuo-Jung Su <dantesu@faraday-tech.com>
> CC: Marek Vasut <marex@denx.de>

Same rambling as for the other patch, bits should have proper names defined in 
the fotg_....h header file. You should avoid calling 
dcache_enable()/dcache_disable() throughout the driver, why do you need to do 
that? Rather implement proper cacheline flushing/invalidation.

Best regards,
Marek Vasut