Received: from eggs.gnu.org ([208.118.235.92]:45018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXC41-0006Hz-RX for qemu-devel@nongnu.org; Tue, 30 Apr 2013 11:01:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXC3x-0005ov-2R for qemu-devel@nongnu.org; Tue, 30 Apr 2013 11:01:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXC3w-0005on-Rc for qemu-devel@nongnu.org; Tue, 30 Apr 2013 11:01:49 -0400 Date: Tue, 30 Apr 2013 17:01:44 +0200 From: Igor Mammedov Message-ID: <20130430170144.3ad54345@nial.usersys.redhat.com> In-Reply-To: References: <20130430143043.GE28606@otherpad.lan.raisama.net> <1367333317-31468-1-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, afaerber@suse.de On Tue, 30 Apr 2013 15:55:24 +0100 Peter Maydell wrote: > On 30 April 2013 15:48, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > compile tested only ... > > > > --- > > hw/arm/realview.c | 16 ++++------------ > > hw/arm/versatilepb.c | 5 ++--- > > Anything that's only touching these two boards is clearly > not considering the whole situation -- more boards than > just these two have a board specific default CPU. that was only ones that used QEMUMachineArgs.cpu_model as storage for dynamically setting default value. Other machines should be checked and cleaned up as well. perhaps commit subj should be: target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model for realview and versatilepb boards. > > thanks > -- PMM