Received: from eggs.gnu.org ([208.118.235.92]:46835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXF2E-0003yi-QB for qemu-devel@nongnu.org; Tue, 30 Apr 2013 14:12:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXF2D-0004Ll-HZ for qemu-devel@nongnu.org; Tue, 30 Apr 2013 14:12:14 -0400 Received: from mail-ee0-f48.google.com ([74.125.83.48]:65053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXF2D-0004Lf-Ax for qemu-devel@nongnu.org; Tue, 30 Apr 2013 14:12:13 -0400 Received: by mail-ee0-f48.google.com with SMTP id d49so408417eek.21 for ; Tue, 30 Apr 2013 11:12:12 -0700 (PDT) Date: Tue, 30 Apr 2013 20:12:03 +0200 From: "Edgar E. Iglesias" Message-ID: <20130430181203.GU4915@smtp.vpn> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH for-1.5 v3 00/15] Xilinx SPIPS fixes round 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.crosthwaite@xilinx.com Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On Mon, Apr 22, 2013 at 03:11:19PM +1000, peter.crosthwaite@xilinx.com wrote: > From: Peter Crosthwaite > > Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by > a number of bugs/incompletnesses found by some (very) rigourous test > vectors. Hi Peter, The series looks good to me. Once you fix the build issues Peter Maydell noticed, feel free to add my Reviewed-by tag. Cheers, Edgar > > changed from v3: > Fixed break after goto (PMM review) > > > Peter Crosthwaite (15): > xilinx_spips: seperate SPI and QSPI as two classes > xilinx_spips: Make interrupts clear on read > xilinx_spips: Inhibit interrupts in LQSPI mode > xilinx_spips: Add verbose LQSPI debug output > xilinx_spips: Fix QSPI FIFO size > xilinx_spips: Trash LQ page cache on mode change > xilinx_spips: Add automatic start support > xilinx_spips: Implement automatic CS > xilinx_spips: lqspi: Dont touch config register > xilinx_spips: Fix CTRL register RW bits > xilinx_spips: Fix striping behaviour > xilinx_spips: Debug msgs for Snoop state > xilinx_spips: Multiple debug verbosity levels > xilinx_spips: lqspi: Push more data to tx-fifo > xilinx_spips: lqspi: Fix byte/misaligned access > > hw/arm/xilinx_zynq.c | 2 +- > hw/ssi/xilinx_spips.c | 320 ++++++++++++++++++++++++++++++++++++++----------- > 2 files changed, 249 insertions(+), 73 deletions(-) >