From: Damien Lespiau Subject: Re: [PATCH] drm/i915: implement WADPOClockGatingDisable for LPT Date: Tue, 7 May 2013 14:30:15 +0100 Message-ID: <20130507133014.GC32312@strange.amr.corp.intel.com> References: <1366233349-18956-1-git-send-email-przanoni@gmail.com> <20130507131005.GB32312@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 960D0E5D09 for ; Tue, 7 May 2013 06:30:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130507131005.GB32312@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, May 07, 2013 at 02:10:05PM +0100, Damien Lespiau wrote: > On Wed, Apr 17, 2013 at 06:15:49PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > This should prevent mode set failures on LPT. > > > > Signed-off-by: Paulo Zanoni > > --- > > drivers/gpu/drm/i915/intel_pm.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index 413877d..15ff0ac 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -3758,6 +3758,11 @@ static void lpt_init_clock_gating(struct drm_device *dev) > > I915_WRITE(SOUTH_DSPCLK_GATE_D, > > I915_READ(SOUTH_DSPCLK_GATE_D) | > > PCH_LP_PARTITION_LEVEL_DISABLE); > > + > > + /* WADPOClockGatingDisable */ > > + I915_WRITE(_TRANSA_CHICKEN1, > > + I915_READ(_TRANSA_CHICKEN1) | > > + TRANS_CHICKEN1_DP0UNIT_GC_DISABLE); > > Don't you need to do that for each pipe? (like the cpt_ version does)? Also it's DP0 (zero), not DPO. -- Damien