From: Daniel Vetter Subject: Re: [PATCH] drm/i915: fix hotplug event bit tracking Date: Wed, 8 May 2013 14:44:37 +0200 Message-ID: <20130508124437.GQ5763@phenom.ffwll.local> References: <1367928629-16962-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FEECE632A for ; Wed, 8 May 2013 05:41:30 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id o10so893695eaj.8 for ; Wed, 08 May 2013 05:41:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1367928629-16962-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: Egbert Eich , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 07, 2013 at 03:10:29PM +0300, Jani Nikula wrote: > commit 142e239849c800f9dc23f828762873073f612d3f > Author: Egbert Eich > Date: Thu Apr 11 15:57:57 2013 +0200 > > drm/i915: Add bit field to record which pins have received HPD events (v3) > > added a bit field for hotplug event tracking. There ended up being three > different v3 of the patch: [1], [2], and [3]. Apparently [1] was the > correct one, but some frankenstein combination of the three got > committed, which reversed the logic for setting the hotplug bits and > misplaced a continue statement, skipping the hotplug irq storm handling > altogether. > > This lead to broken hotplug detection, bisected to > commit 321a1b3026ea194dd084cf3bda1e235b2986b0af > Author: Egbert Eich > Date: Thu Apr 11 16:00:26 2013 +0200 > > drm/i915: Only reprobe display on encoder which has received an HPD event (v2) > > which uses the incorrectly set hotplug event bits. > > Fix the mess. > > [1] http://mid.gmane.org/1366112220-7638-6-git-send-email-eich@suse.de > [2] http://mid.gmane.org/1365688677-13682-1-git-send-email-eich@suse.de > [3] http://mid.gmane.org/1365688996-13874-1-git-send-email-eich@suse.de > > Signed-off-by: Jani Nikula /me hangs head in shame Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch