Received: from eggs.gnu.org ([208.118.235.92]:57964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaUpc-0006YF-Jo for qemu-devel@nongnu.org; Thu, 09 May 2013 13:40:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaUpa-0001fO-UZ for qemu-devel@nongnu.org; Thu, 09 May 2013 13:40:40 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:35950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaUpa-0001fE-NW for qemu-devel@nongnu.org; Thu, 09 May 2013 13:40:38 -0400 Date: Thu, 9 May 2013 19:40:34 +0200 From: Aurelien Jarno Message-ID: <20130509174034.GB19954@ohm.aurel32.net> References: <1367388411-13193-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1367388411-13193-1-git-send-email-hpoussin@reactos.org> Subject: Re: [Qemu-devel] [PATCH for 1.5] Revert "target-i386: Use movcond to implement rotate flags." List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-15?Q?Herv=E9?= Poussineau Cc: qemu-devel@nongnu.org, Richard Henderson On Wed, May 01, 2013 at 08:06:51AM +0200, Hervé Poussineau wrote: > This commit breaks boot of MS-DOS 6.22, which stops at: > MODE CON CODEPAGE PREPARE=((850) C:\DOS\EGA.CPI) > > This reverts part of commit 34d80a55ff8517fd37bcfea5063b9797e2bd9132. > > Signed-off-by: Hervé Poussineau > --- > > checkpatch.pl complains about this patch, but I preferred to do a simple > revert than to fix code style. > > target-i386/translate.c | 98 ++++++++++++++++++++++------------------------- > 1 file changed, 45 insertions(+), 53 deletions(-) The actual bug is the same than the one fixed in commit 089305ac, but for the immediate case. I have just send a patch to fix the issue. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net