From: Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= Subject: Re: [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge for IGD passthrough [and 2 more messages] Date: Fri, 10 May 2013 12:40:36 +0300 Message-ID: <20130510094036.GS11427@reaktio.net> References: <20775.45924.670290.551847@mariner.uk.xensource.com> <512B46A402000078000C0B3B@nat28.tlf.novell.com> <20779.18914.422564.346844@mariner.uk.xensource.com> <512B591702000078000C0BCE@nat28.tlf.novell.com> <20873.13822.177086.581233@mariner.uk.xensource.com> <20130509131706.GJ11427@reaktio.net> <518CD61F02000078000D5085@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <518CD61F02000078000D5085@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Campbell , Stefano Stabellini , George Dunlap , Ian Jackson , "G.R." , xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, May 10, 2013 at 10:12:31AM +0100, Jan Beulich wrote: > >>> On 09.05.13 at 15:17, Pasi K=E4rkk=E4inen wrote: > > Jan: Can you please re-check 2/3 and 3/3 ? = > > = > > "[PATCH 2/3] qemu-xen-trad: Correctly expose PCH ISA bridge for IGD = > > passthrough": > > http://lists.xen.org/archives/html/xen-devel/2013-02/msg00536.html = > = > I'm not sure what you're asking for - my comments there weren't > followed up with by the submitter, so I also don't have anything > new to add. I don't think I've seen a cleaned up patch so far. > = Ok. Thanks for clarifying that (I wasn't sure if there was still unresolved= issues or not). > > "[PATCH 3/3] qemu-xen-trad: IGD passthrough: Expose vendor specific pci= cap on = > > host bridge": > > http://lists.xen.org/archives/html/xen-devel/2013-02/msg00538.html = > = > Quite similar here, except that Jean was also asked to comment > on why some previously existing code is the way it is, and I don't > think any explanation was ever given. > Ok. = = > I can only second what Ian already said - pinging on a patch that > has responses missing from the originator is bad practice. If you > wanted to ping anyone, you'd have to ping those who failed to > answer questions raised to them, not give the appearance of > requesting a patch to be taken that is only half baked. > = I mostly wanted to clarify the situation with these patches, I'm not suggesting to merge half baked patches. = So thanks for the comments! -- Pasi