From: "J. Bruce Fields" Date: Sat, 11 May 2013 18:43:35 +0000 Subject: Re: [patch] svcauth_gss: fix error code in use_gss_proxy() Message-Id: <20130511184335.GD15765@fieldses.org> List-Id: References: <20130511161349.GA20451@elgon.mountain> In-Reply-To: <20130511161349.GA20451@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Trond Myklebust , "David S. Miller" , "Eric W. Biederman" , Simo Sorce , Stanislav Kinsbursky , Wei Yongjun , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, May 11, 2013 at 07:13:49PM +0300, Dan Carpenter wrote: > This should return zero on success and -EBUSY on error so the type > needs to be int instead of bool. Oops, you're right--thanks. Applying.--b. > > Signed-off-by: Dan Carpenter > > diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c > index 871c73c..2c6a1ec 100644 > --- a/net/sunrpc/auth_gss/svcauth_gss.c > +++ b/net/sunrpc/auth_gss/svcauth_gss.c > @@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net) > > #ifdef CONFIG_PROC_FS > > -static bool set_gss_proxy(struct net *net, int type) > +static int set_gss_proxy(struct net *net, int type) > { > struct sunrpc_net *sn = net_generic(net, sunrpc_net_id); > int ret = 0;