From: Tim Deegan Subject: Re: [PATCH 2/2] x86/hvm: fix corrupt ACPI PM-Timer during live migration Date: Thu, 16 May 2013 10:54:24 +0100 Message-ID: <20130516095424.GA92045@ocelot.phlegethon.org> References: <51247E56.4060904@jp.fujitsu.com> <5138C72802000078000C3FB0@nat28.tlf.novell.com> <514A9BC4.40508@jp.fujitsu.com> <514AB78A.3010109@jp.fujitsu.com> <514AE87902000078000C76E3@nat28.tlf.novell.com> <514BB003.1070903@jp.fujitsu.com> <514C1E2F02000078000C7A93@nat28.tlf.novell.com> <5193B85702000078000D684D@nat28.tlf.novell.com> <51946E2E.1040707@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <51946E2E.1040707@jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Kouya Shimura Cc: Keir Fraser , Alex Bligh , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org At 14:27 +0900 on 16 May (1368714430), Kouya Shimura wrote: > Hi Keir, Tim, > > I attached the patch again. > Can I get an ACK or NACK? Well, I don't think this is suitable for committing: > +#if 0 /* redundant */ > if ( !mode_is(v->domain, delay_for_missed_ticks) ) > return; > +#endif but apart from that it seems OK to me. It's a bit odd to have the platform timers (almost) stop ticking when their controlling vcpu is descheduled but I guess no worse than having them go backwards! So if you fix the '#if 0' (either cut out the code properly or leave it alone, I don't mind which), you can add Reviewed-by: Tim Deegan You'll need an ack from George as well for the release; I suspect that will depend on how much testing you've done. Tim.