Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:47067 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265Ab3EPO5d (ORCPT ); Thu, 16 May 2013 10:57:33 -0400 Date: Thu, 16 May 2013 22:57:07 +0800 From: Liu Bo To: Chris Mason Cc: "miaox@cn.fujitsu.com" , "linux-btrfs@vger.kernel.org" , "alex.btrfs@zadarastorage.com" Subject: Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree Message-ID: <20130516145706.GM20202@liubo.jp.oracle.com> Reply-To: bo.li.liu@oracle.com References: <1368604111-25073-7-git-send-email-miaox@cn.fujitsu.com> <20130516033645.GF20202@liubo.jp.oracle.com> <5194610F.1000603@cn.fujitsu.com> <20130516051556.GH20202@liubo.jp.oracle.com> <51946FD3.5000008@cn.fujitsu.com> <20130516061552.GI20202@liubo.jp.oracle.com> <5194893D.90505@cn.fujitsu.com> <20130516115417.24668.98321@localhost.localdomain> <20130516143138.GL20202@liubo.jp.oracle.com> <20130516143455.24668.84660@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20130516143455.24668.84660@localhost.localdomain> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, May 16, 2013 at 10:34:55AM -0400, Chris Mason wrote: > Quoting Liu Bo (2013-05-16 10:31:39) > > On Thu, May 16, 2013 at 07:54:17AM -0400, Chris Mason wrote: > > > Quoting Miao Xie (2013-05-16 03:22:37) > > > > > I must say that the patch itself looks harmless, the reason is not good enough. > > > > > > > > I don't agree with you. > > > > It is perishing that The memory reclaim task is blocked for a long time. We should avoid > > > > this problem. > > > > > > synchronize_rcu and friends can take a very very long time. I like this > > > patch as a way to avoid them, it's just keeps the whole kernel moving. > > > > > > -chris > > > > Okay, that teaches me another lesson, thanks Miao :) > > Actually using the rcu api isn't a huge impact. It's just the > synchronize_rcu variants that should be avoided ;) > > -chris > Now that it's so slow, I wonder why not use call_srcu() instead? thanks, liubo