From: Thomas Monjalon Subject: Re: [PATCH] lib: set version 1.2.3r2 and more helper macros Date: Fri, 17 May 2013 16:46:00 +0200 Message-ID: <201305171646.00572.thomas.monjalon@6wind.com> References: <1367940644-13357-1-git-send-email-thomas.monjalon@6wind.com> <5195F477.1050501@6wind.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Olivier MATZ Return-path: In-Reply-To: <5195F477.1050501-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 17/05/2013 11:12, Olivier MATZ : > > @@ -75,7 +87,8 @@ rte_version(void) { > > > > return RTE_VER_PREFIX" " > > > > RTE_STR(RTE_VER_MAJOR)"." > > RTE_STR(RTE_VER_MINOR)"." > > > > - RTE_STR(RTE_VER_PATCH_LEVEL); > > + RTE_STR(RTE_VER_PATCH_LEVEL)"r" > > + RTE_STR(RTE_VER_PATCH_RELEASE); > > > > } > > In this patch, do you think it could be useful to add > a #ifdef RTE_VER_PATCH_RELEASE ? The idea is to return > "1.2.3" if there is no patch release and "1.2.3r4" in > the dpdk.org case. As a result this patch would be integrable > in Intel DPDK mainline. This patch introduce RTE_VER_PATCH_RELEASE so #ifdef RTE_VER_PATCH_RELEASE is always true. I don't see why a commercial version of the DPDK would like to apply part of this patch. -- Thomas