From: Guenter Roeck Date: Sun, 19 May 2013 15:04:42 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (lm63) Drop redundant safety on cache lifetime Message-Id: <20130519150442.GB20607@roeck-us.net> List-Id: References: <20130519165629.15313591@endymion.delvare> In-Reply-To: <20130519165629.15313591@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Sun, May 19, 2013 at 04:56:29PM +0200, Jean Delvare wrote: > time_after (as opposed to time_after_equal) already ensures that the > cache lifetime is at least as much as requested. There is no point in > manually adding another jiffy to that value, and this can confuse the > reader into wrong interpretation. > > Signed-off-by: Jean Delvare Acked-by: Guenter Roeck > Cc: Imre Deak > --- > drivers/hwmon/lm63.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > --- linux-3.10-rc1.orig/drivers/hwmon/lm63.c 2013-05-19 16:34:42.927249143 +0200 > +++ linux-3.10-rc1/drivers/hwmon/lm63.c 2013-05-19 16:34:50.933419344 +0200 > @@ -247,9 +247,8 @@ static struct lm63_data *lm63_update_dev > > mutex_lock(&data->update_lock); > > - next_update = data->last_updated > - + msecs_to_jiffies(data->update_interval) + 1; > - > + next_update = data->last_updated + > + msecs_to_jiffies(data->update_interval); > if (time_after(jiffies, next_update) || !data->valid) { > if (data->config & 0x04) { /* tachometer enabled */ > /* order matters for fan1_input */ > > > -- > Jean Delvare > > _______________________________________________ > lm-sensors mailing list > lm-sensors@lm-sensors.org > http://lists.lm-sensors.org/mailman/listinfo/lm-sensors > _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors