From: s.hauer@pengutronix.de (Sascha Hauer) Date: Thu, 23 May 2013 14:36:42 +0200 Subject: [PATCH] ARM: dts: imx: fix clocks for cspi In-Reply-To: <1369311059.366490908@f190.mail.ru> References: <1369309085-31146-1-git-send-email-jonas@microbit.se> <1369310474.965158503@f320.mail.ru> <1369311059.366490908@f190.mail.ru> Message-ID: <20130523123642.GK32299@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 23, 2013 at 04:10:59PM +0400, Alexander Shiyan wrote: > > > The CSPI controller has only one clock, but the driver spi-imx.c needs clock "per" to calculate bitrate divisor. > > > > > > Signed-off-by: Jonas Andersson > > > --- > > > arch/arm/boot/dts/imx25.dtsi | 12 ++++++------ > > > arch/arm/boot/dts/imx27.dtsi | 6 +++--- > > > arch/arm/boot/dts/imx51.dtsi | 2 +- > > > arch/arm/boot/dts/imx53.dtsi | 2 +- > > > 4 files changed, 11 insertions(+), 11 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > > > index d2550e0..7011539 100644 > > > --- a/arch/arm/boot/dts/imx25.dtsi > > > +++ b/arch/arm/boot/dts/imx25.dtsi > > > @@ -141,8 +141,8 @@ > > > #size-cells = <0>; > > > compatible = "fsl,imx25-cspi", "fsl,imx35-cspi"; > > > reg = <0x43fa4000 0x4000>; > > > - clocks = <&clks 62>; > > > - clock-names = "ipg"; > > > + clocks = <&clks 62>, <&clks 62>; > > > + clock-names = "ipg", "per"; > > > interrupts = <14>; > > > status = "disabled"; > > > }; > > Sorry, typo. > > > Why you do not use "dummy" clock for "per" here? > > *for "ipg" Because the same clock is used for the register clock and the baudrate clock. You have to enable the ipg clock to access registers. > > > This variant will request/enable one clock two times. Indeed, but what's the problem with this? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |