From: Peter Zijlstra Subject: Re: OOPS in perf_mmap_close() Date: Thu, 23 May 2013 17:26:11 +0200 Message-ID: <20130523152611.GE23650@twins.programming.kicks-ass.net> References: <20130523044803.GA25399@ZenIV.linux.org.uk> <20130523125218.GB23650@twins.programming.kicks-ass.net> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: trinity-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vince Weaver Cc: Al Viro , linux-kernel@vger.kernel.org, Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , trinity@vger.kernel.org On Thu, May 23, 2013 at 10:10:36AM -0400, Vince Weaver wrote: > > I can confirm your patch avoids the oops on my machine. > > It does lead to interesting behavior if I run the sample program > multiple times (with added printfs): > > vince@core2:~$ ./perf_mmap_close_bug > mmap1=0x7f06a6e90000 > mmap2=0x7f06a6e7f000 > vince@core2:~$ ./perf_mmap_close_bug > mmap1=0x7f878a138000 > mmap2=0x7f878a127000 > vince@core2:~$ ./perf_mmap_close_bug > mmap1=0xffffffffffffffff > Error opening fd2 Invalid argument > > and then it never successfully completes again. Is this unexpected > behavior? Sounds weird to me, I'll see if I can reproduce/understand.