From: Jean Delvare Date: Fri, 24 May 2013 07:05:50 +0000 Subject: Re: [lm-sensors] [PATCH v3] hwmon (ds1621): Remove detection function Message-Id: <20130524090550.14e645cb@endymion.delvare> List-Id: References: <1369326142-30781-1-git-send-email-rob.coulson@gmail.com> In-Reply-To: <1369326142-30781-1-git-send-email-rob.coulson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org Hi Robert, On Thu, 23 May 2013 09:22:22 -0700, Robert Coulson wrote: > Due to a lack of device and vendor identification registers, the > Dallas/Maxim DS16xx devices cannot be uniquely detected, sometimes > resulting in false positives. Therefore, the detection function is > being removed in favor of explicit device instantiation. > > Signed-off-by: Robert Coulson > --- > Documentation/hwmon/ds1621 | 25 +++++++++++------------ > drivers/hwmon/ds1621.c | 48 -------------------------------------------- > 2 files changed, 12 insertions(+), 61 deletions(-) > > v2: > - removed detect function references in ds1621 documentation > - replaced deprecated with removed and fixed a spelling error > v3: > - removed scanned addresses info, tables, and list > (...) Thanks for the update, looks good to me. Acked-by: Jean Delvare Guenter, please pick and apply. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors