Received: from eggs.gnu.org ([208.118.235.92]:46078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ug11l-0001zv-JO for qemu-devel@nongnu.org; Fri, 24 May 2013 19:04:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ug11k-0007UH-71 for qemu-devel@nongnu.org; Fri, 24 May 2013 19:04:01 -0400 Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:38768 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ug11k-0007UB-2f for qemu-devel@nongnu.org; Fri, 24 May 2013 19:04:00 -0400 Date: Fri, 24 May 2013 19:01:49 -0400 From: Brad Smith Message-ID: <20130524230148.GG30328@rox.home.comstyle.com> References: <20130508113924.GA7698@rox.home.comstyle.com> <519FEEEB.40004@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519FEEEB.40004@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org On Sat, May 25, 2013 at 12:51:23AM +0200, Laszlo Ersek wrote: > On 05/08/13 13:39, Brad Smith wrote: > > Remove the OSS support for OpenBSD. The OSS API has not been usable > > for quite some time. > > > > Signed-off-by: Brad Smith > > > > diff --git a/audio/ossaudio.c b/audio/ossaudio.c > > index 00be9c9..007c641 100644 > > --- a/audio/ossaudio.c > > +++ b/audio/ossaudio.c > > @@ -25,11 +25,7 @@ > > #include > > #include > > #include > > -#ifdef __OpenBSD__ > > -#include > > -#else > > #include > > -#endif > > #include "qemu-common.h" > > #include "qemu/main-loop.h" > > #include "qemu/host-utils.h" > > diff --git a/configure b/configure > > index 9439f1c..89dda5b 100755 > > --- a/configure > > +++ b/configure > > @@ -468,8 +468,7 @@ OpenBSD) > > bsd="yes" > > make="${MAKE-gmake}" > > audio_drv_list="oss" > > - audio_possible_drivers="oss sdl esd" > > - oss_lib="-lossaudio" > > + audio_possible_drivers="sdl esd" > > ;; > > Darwin) > > bsd="yes" > > > > Shouldn't the default audio driver list ($audio_drv_list) be a subset of > the possible driver list? My mistake. A new patch sent. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.