From: Tom Rini Date: Tue, 28 May 2013 13:52:11 -0400 Subject: [U-Boot] [RFC PATCH 4/7] Add Kconfig scripts and related material In-Reply-To: <20130528103159.460C.AA925319@jp.panasonic.com> References: <20130527110827.45FC.AA925319@jp.panasonic.com> <20130528103159.460C.AA925319@jp.panasonic.com> Message-ID: <20130528175211.GG5829@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, May 28, 2013 at 10:31:59AM +0900, Masahiro Yamada wrote: [snip] > So, my first request is that this commit should just import > scripts as they are in Linux Kernel (plus renaming from > Makefile to Makefile.kbuild) > > All modification you make for U-Boot should be pushed into the > next commit "Adjust Kconfig scripts for use by U-Boot". > > I think this would be helpful for reviewers to track which lines > are changed. > > > The seconde request is subject of personal preference but I like > the white spaces to be kept untouched when importing files > from another project. > > Although I was not sure they were corrected by you, > I noticed some white space errors diffs when > comparing your patches with Linux Kernel makefiles. > The reason is, as you mentioned in commit log, to minimise conflicts > with future Kbuild updates. Agreed on both points. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: