From: Tom Rini Date: Wed, 29 May 2013 09:08:55 -0400 Subject: [U-Boot] [PATCH 09/12] mmc: omap_hsmmc: add mmc1 pbias, ldo1 In-Reply-To: <1369825367-4537-10-git-send-email-lokeshvutla@ti.com> References: <1369825367-4537-1-git-send-email-lokeshvutla@ti.com> <1369825367-4537-10-git-send-email-lokeshvutla@ti.com> Message-ID: <20130529130855.GK11917@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, May 29, 2013 at 04:32:44PM +0530, Lokesh Vutla wrote: > From: Balaji T K > > add dra mmc pbias support and ldo1 power on > > Signed-off-by: Balaji T K > Signed-off-by: Lokesh Vutla [snip] > + udelay(150); /* wait 10 us */ > + value |= SDCARD_PWRDNZ; > + writel(value, (*ctrl)->control_pbias); > + udelay(150); /* wait 10 us */ That's not 10us. > + val = 0x2b; /* (3 -.9)*20 +1 */ Consistent spacing in the math please (and leading 0). > + if (palmas_i2c_write_u8(0x58, LDO1_CTRL, val)) { No magic values please. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: