From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: fixed EDID/sink-based bpp clamping Date: Sat, 1 Jun 2013 21:10:03 +0200 Message-ID: <20130601191003.GI15743@phenom.ffwll.local> References: <1370108756-1948-1-git-send-email-daniel.vetter@ffwll.ch> <20130601175239.GG11399@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f171.google.com (mail-ea0-f171.google.com [209.85.215.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 477DFE605C for ; Sat, 1 Jun 2013 12:10:08 -0700 (PDT) Received: by mail-ea0-f171.google.com with SMTP id b15so2337295eae.30 for ; Sat, 01 Jun 2013 12:10:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130601175239.GG11399@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Sat, Jun 01, 2013 at 06:52:39PM +0100, Chris Wilson wrote: > On Sat, Jun 01, 2013 at 07:45:55PM +0200, Daniel Vetter wrote: > > Since this is run in the compute config stage we need to check > > the new_ pointers, not the current modeset layout. Also there > > was a little logic bug in properly skipping connectors. This has > > been broken when moving the pipe bpp selection in > > > > commit 4e53c2e010e531b4a014692199e978482d471c7e > > Author: Daniel Vetter > > Date: Wed Mar 27 00:44:58 2013 +0100 > > > > drm/i915: precompute pipe bpp before touching the hw > > > > To avoid too much casting switch from drm_ to intel_ types. > > > > Also add a bit of debug output to help reconstructing what's going > > on. > > Baffling. It is really hard to tell what is going on, so perhaps it is > worth investing in some more descriptive names. How about: > struct drm_display_info *desired = &connector->base.display_info ? > Or some other name? And an indication in the function name at which > stage this is meant to run? I guess renaming the function to pipe_config_compute_bpp would help (since it doesn't really set anything). And maybe extracting the sink based bpp limiting into it's own function since it's a bit magic. I'll see whether I can polish this turd some more. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch