Received: from eggs.gnu.org ([2001:4830:134:3::10]:52953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uj7QV-00044U-Hm for qemu-devel@nongnu.org; Sun, 02 Jun 2013 08:30:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uj7QU-0004S7-8s for qemu-devel@nongnu.org; Sun, 02 Jun 2013 08:30:23 -0400 Received: from ozlabs.org ([203.10.76.45]:32916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uj7QT-0004Rv-Ue for qemu-devel@nongnu.org; Sun, 02 Jun 2013 08:30:22 -0400 Date: Sun, 2 Jun 2013 22:30:18 +1000 From: Anton Blanchard Message-ID: <20130602223018.440457e3@kryten> In-Reply-To: <20130602222452.1b0fdbd1@kryten> References: <20130602222452.1b0fdbd1@kryten> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 4/4] tcg-ppc64: rotr_i32 rotates wrong amount List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: david@gibson.dropbear.id.au, agraf@suse.de, rth@twiddle.net, aurelien@aurel32.net Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org rotr_i32 calculates the amount to left shift and puts it into a temporary, but then doesn't use it when doing the shift. Cc: qemu-stable@nongnu.org Signed-off-by: Anton Blanchard --- Index: b/tcg/ppc64/tcg-target.c =================================================================== --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -1661,7 +1661,7 @@ static void tcg_out_op (TCGContext *s, T tcg_out_rlw(s, RLWINM, args[0], args[1], 32 - args[2], 0, 31); } else { tcg_out32(s, SUBFIC | TAI(0, args[2], 32)); - tcg_out32(s, RLWNM | SAB(args[1], args[0], args[2]) + tcg_out32(s, RLWNM | SAB(args[1], args[0], 0) | MB(0) | ME(31)); } break;