From: Daniel Vetter Subject: Re: [PATCH 5/7] drm/i915: Use container_of() in the fbdev code Date: Mon, 3 Jun 2013 14:01:29 +0200 Message-ID: <20130603120129.GO15743@phenom.ffwll.local> References: <1370020027-27595-1-git-send-email-ville.syrjala@linux.intel.com> <1370020027-27595-6-git-send-email-ville.syrjala@linux.intel.com> <20130603100830.GL11399@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20130603100830.GL11399@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Jun 03, 2013 at 11:08:30AM +0100, Chris Wilson wrote: > On Fri, May 31, 2013 at 08:07:05PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > Use container_of() instead of a cast to get struct intel_fbdev > > from struct drm_fb_helper. > > = > > Also populate the fb_info->par correctly with the drm_fb_helper pointer > > instead of the intel_fbdev pointer. > > = > > There's no actual functional change since the drm_fb_helper happens to > > be the first member inside intel_fbdev. > Reviewed-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch