From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: fix EDID/sink-based bpp clamping Date: Tue, 4 Jun 2013 13:53:14 +0200 Message-ID: <20130604115314.GY15743@phenom.ffwll.local> References: <20130602100952.GH11399@cantiga.alporthouse.com> <1370172384-24026-1-git-send-email-daniel.vetter@ffwll.ch> <1370172384-24026-2-git-send-email-daniel.vetter@ffwll.ch> <20130603075029.GB17485@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com [209.85.215.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C82DE5F22 for ; Tue, 4 Jun 2013 04:53:19 -0700 (PDT) Received: by mail-ea0-f173.google.com with SMTP id n15so97901ead.32 for ; Tue, 04 Jun 2013 04:53:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130603075029.GB17485@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Jun 03, 2013 at 08:50:29AM +0100, Chris Wilson wrote: > On Sun, Jun 02, 2013 at 01:26:24PM +0200, Daniel Vetter wrote: > > Since this is run in the compute config stage we need to check > > the new_ pointers, i.e the stage output routing, not the current > > modeset layout. Also there was a little logic bug in properly skipping > > connectors: The old code did not skip any unused connectors and so > > clamped to whatever was left in there (usually 0 if that connector > > hasn't seen a EDID 1.4 screen ever since boot-up). > > > > This has been broken when moving the pipe bpp selection in > > > > commit 4e53c2e010e531b4a014692199e978482d471c7e > > Author: Daniel Vetter > > Date: Wed Mar 27 00:44:58 2013 +0100 > > > > drm/i915: precompute pipe bpp before touching the hw > > > > To avoid too much casting switch from drm_ to intel_ types. > > > > Also add a bit of debug output to help reconstructing what's going > > on. > > > > v2: Try to clarify this a bit: > > - s/pipe_config_set_bpp/compute_baseline_pipe_bpp/ to make it clearer > > at which stage this function is run. Also add a comment about what > > it does. > > - Extract the sink clamping into it's own function. > > > > v3: Actually make it compile. > > > > v4: Split out all the prep refactoring to make the bugfix stick out > > really badly. Also elaborate a bit in the commit message about the > > nature of the bugfix. > > > > Cc: Chris Wilson > > Signed-off-by: Daniel Vetter > > Yes, that does show how badly I misread the first patch! > For both, Reviewed-by: Chris Wilson Both merged, thanks for the review. I'll ping QA to test the 30bpp patch, too. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch