From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Try harder to disable trickle feed on VLV Date: Tue, 4 Jun 2013 15:19:12 +0100 Message-ID: <20130604141912.GD2052@cantiga.alporthouse.com> References: <1369139314-3003-1-git-send-email-ville.syrjala@linux.intel.com> <1369139314-3003-4-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id F3572E5F6E for ; Tue, 4 Jun 2013 07:19:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1369139314-3003-4-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 21, 2013 at 03:28:34PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > The specs are a bit unclear whether the per-plane trickle feed disable > control exists on VLV. There is another trickle feed disable control > in the MI_ARB register. > = > Based on some quick register dumps from Jani's VLV machine, the per-plane > bits don't actually seem to exist, so I'm guessing we should use the > MI_ARB method instead. I think neither. I'm guessing this behaviour is covered by 'Note: On mobile products this bit will be ignored such that Trickle Feed is always disabled.' in the DSP.CNTR spec. And I don't think MI_ARB_STATE is applicable as it wasn't used for the display block VLV was based upon. Being VPN-less I can't actually dig through the VLV bspec to confirm. -Chris -- = Chris Wilson, Intel Open Source Technology Centre