From: Wolfgang Denk Date: Tue, 04 Jun 2013 17:00:45 +0200 Subject: [U-Boot] =?utf-8?q?net=2C_cpsw=3A_disable_gigabit_support_through?= =?utf-8?q?_plattform_data?= In-Reply-To: <1370335914-14027-1-git-send-email-hs@denx.de> References: <1370335914-14027-1-git-send-email-hs@denx.de> Message-ID: <20130604150045.3454038306D@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Heiko, In message <1370335914-14027-1-git-send-email-hs@denx.de> you wrote: > add possibility to disable gigabit support through > plattform data. Current boards should not be affected > through this patch. ... > + if (phy->speed == 1000) { > + if (priv->data.gigabit_en) { > + mac_control |= GIGABITEN; > + } else { > + /* Disable gigabit as it's non-functional */ > + mac_control &= ~GIGABITEN; > + phy->speed = 100; Is this reliable? I mean, how do we know it's a 100 Mbps connection (and not for example a 10 Mbs one) ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Systems programmers are the high priests of a low cult. -- R.S. Barton