From: heiko@sntech.de (Heiko =?iso-8859-1?q?St=FCbner?=)
Date: Mon, 10 Jun 2013 15:10:51 +0200
Subject: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs
In-Reply-To: <CACRpkdaEcZZ3NZzwKOhUPjvFg+bSZ=UbpyPT2EBcAfVv1-EsKA@mail.gmail.com>
References: <201306090159.05383.heiko@sntech.de>
 <201306090201.17739.heiko@sntech.de>
 <CACRpkdaEcZZ3NZzwKOhUPjvFg+bSZ=UbpyPT2EBcAfVv1-EsKA@mail.gmail.com>
Message-ID: <201306101510.51961.heiko@sntech.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Am Montag, 10. Juni 2013, 15:00:41 schrieb Linus Walleij:
> On Sun, Jun 9, 2013 at 2:01 AM, Heiko St?bner <heiko@sntech.de> wrote:
> 
> (...)
> 
> > +#include <linux/irqchip/chained_irq.h>
> > +#include <linux/clk-provider.h>
> > +#include <dt-bindings/pinctrl/rockchip.h>
> 
> Hm I don't know if we're supposed to do things like this actually.
> 
> It depends on whether the <dt-bindings/*> hierarchy is supposed
> to stay in the kernel after the device trees are moved out to a
> separate repo.
> 
> Grant/Rob, shall we do this in drivers?

we can get rid of it, if it's controversial.

The only constant that gets used is RK_FUNC_GPIO in 
rockchip_pmx_gpio_set_direction and rockchip_irq_set_type to not have arbitary 
"0"-values when switching to the gpio function.

So it wouldn't be problem to simply keep this constant in the driver itself 
instead of including the dt-binding constants.