From: Alexander Frolkin Subject: Re: [PATCH] Sloppy TCP, SH rebalancing, SHP scheduling Date: Mon, 17 Jun 2013 09:32:04 +0100 Message-ID: <20130617083204.GA13101@eldamar.org.uk> References: <20130607081252.GC11902@eldamar.org.uk> <20130611083806.GA25531@eldamar.org.uk> <20130612141018.GC29327@eldamar.org.uk> <20130613141804.GB31356@eldamar.org.uk> <20130614102210.GA31800@eldamar.org.uk> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: lvs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julian Anastasov Cc: lvs-devel@vger.kernel.org Hi, > Add 'break' for this case when dest is NULL (no > dests). Then we have to add {} for all branches as per > CodingStyle: > > if (!is_unavailable(dest)) > return dest; > if (dest) { > IP_VS_DBG_BUF > } else { > IP_VS_DBG > break; > } So if dest is NULL, there is no point trying to choose a different server? Alex