From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Allow contexts to be specified for unsupported rings Date: Tue, 25 Jun 2013 17:10:42 +0100 Message-ID: <20130625161042.GD23824@cantiga.alporthouse.com> References: <1372175222-27622-1-git-send-email-mika.kuoppala@intel.com> <1372175222-27622-3-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id CA44AE5DBC for ; Tue, 25 Jun 2013 09:10:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1372175222-27622-3-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 25, 2013 at 06:47:02PM +0300, Mika Kuoppala wrote: > From: Chris Wilson > > As our contexts are more general than the logical contexts supported by > the hardware, for instance they allow per context hangcheck tracking, it > is beneficial to group tasks across rings belonging to the same context. > Context switching is already a no-op for unsupported rings, we just > suffered from a little too overzealous parameter checking on entry - now > we just check that the context is valid. We have to drop this temporarily as the validation was being provided by i915_gem_context_get_hang_stats(), which is now notably absent. -Chris -- Chris Wilson, Intel Open Source Technology Centre