From: Wolfgang Denk Date: Tue, 25 Jun 2013 20:24:03 +0200 Subject: [U-Boot] [PATCH 1/2] arm: add support for LaCie CloudBox In-Reply-To: <1372178945-11528-2-git-send-email-fredo@starox.org> References: <1372178945-11528-1-git-send-email-fredo@starox.org> <1372178945-11528-2-git-send-email-fredo@starox.org> Message-ID: <20130625182403.F02BA380468@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Frederic Leroy, In message <1372178945-11528-2-git-send-email-fredo@starox.org> you wrote: > From: Fr?d?ric Leroy > > The LaCie CloudBox device is a Kirkwood based nas : > > - SoC: Marvell 88F6700 1000Mhz > - SDRAM memory: 256MB DDR2 400Mhz > - Gigabit ethernet: PHY Marvell 88E1318 > - Flash memory: SPI NOR 512KB (Macronix MX25L4005A) > - 1 push button > - 1 reset switch > - 1 SATA port > - 1 LED (bi-color, blue and red) > > Signed-off-by: Fr?d?ric Leroy > --- > board/LaCie/cloudbox/Makefile | 46 +++++++++++ > board/LaCie/cloudbox/cloudbox.c | 104 ++++++++++++++++++++++++ > board/LaCie/cloudbox/cloudbox.h | 36 ++++++++ > board/LaCie/cloudbox/kwbimage.cfg | 167 ++++++++++++++++++++++++++++++++++++++ > boards.cfg | 1 + > include/configs/lacie_kw.h | 8 +- > 6 files changed, 361 insertions(+), 1 deletion(-) > create mode 100644 board/LaCie/cloudbox/Makefile > create mode 100644 board/LaCie/cloudbox/cloudbox.c > create mode 100644 board/LaCie/cloudbox/cloudbox.h > create mode 100644 board/LaCie/cloudbox/kwbimage.cfg The (mandatory) entry to MAINTAINERS is missing. Checkpatch says: WARNING: please, no spaces at the start of a line #253: FILE: board/LaCie/cloudbox/cloudbox.c:82: + return 0;$ WARNING: line over 80 characters #525: FILE: include/configs/lacie_kw.h:79: +#if !defined(CONFIG_NETSPACE_MINI_V2) && !defined(CONFIG_CLOUDBOX) /* No USB ports on these devices */ Please clean these up. > index e2b3b21..dc101d6 100644 > --- a/include/configs/lacie_kw.h > +++ b/include/configs/lacie_kw.h > @@ -44,6 +44,8 @@ > #elif defined(CONFIG_NET2BIG_V2) > #define CONFIG_MACH_TYPE MACH_TYPE_NET2BIG_V2 > #define CONFIG_IDENT_STRING " 2Big v2" > +#elif defined(CONFIG_CLOUDBOX) > +#define CONFIG_IDENT_STRING " CloudBox" Please keep such lists alphabetically sorted. > @@ -115,6 +119,8 @@ > #define CONFIG_SYS_PROMPT "d2v2> " > #elif defined(CONFIG_NET2BIG_V2) > #define CONFIG_SYS_PROMPT "2big2> " > +#elif defined(CONFIG_CLOUDBOX) > +#define CONFIG_SYS_PROMPT "cb> " Same here again. On the other hand, this is actually crap. We should use a common prompt for all these boards, eventually the standard "=> ". Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There is nothing so deadly as not to hold up to people the opportunity to do great and wonderful things, if we wish to stimulate them in an active way." - Dr. Harold Urey, Nobel Laureate in chemistry