From: Chris Wilson Subject: Re: [PATCH] drm/i915: less magic for stolen preallocated objects w/o gtt offset Date: Thu, 4 Jul 2013 12:31:37 +0100 Message-ID: <20130704113137.GC8451@cantiga.alporthouse.com> References: <20130704104143.GA8451@cantiga.alporthouse.com> <1372935988-5075-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 15015E5CC9 for ; Thu, 4 Jul 2013 04:31:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1372935988-5075-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Thu, Jul 04, 2013 at 01:06:28PM +0200, Daniel Vetter wrote: > A magic -1 is a obscure, especially since it's actually passed as an > unsigned, so depens upon the magic sign extension rules in C. This has s/depens/depends/. > been added in > > commit 3727d55e4d85836aa6cb759a965daaef88074150 > Author: Jesse Barnes > Date: Wed May 8 10:45:14 2013 -0700 > > drm/i915: allow stolen, pre-allocated objects to avoid GTT allocation v2 > > Use a proper #define instead. Spotted while reviewing Ben's > drm_mm_create_block changes. > > v2: Cast the constant to u32 since otherwise we again have a type > mismatch. Suggested by Chris Wilson. > > Cc: Ben Widawsky > Cc: Jesse Barnes > Signed-off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre