From: Daniel Vetter Subject: Re: [PATCH] drm/i915: less magic for stolen preallocated objects w/o gtt offset Date: Thu, 4 Jul 2013 14:41:34 +0200 Message-ID: <20130704124134.GE18285@phenom.ffwll.local> References: <20130704104143.GA8451@cantiga.alporthouse.com> <1372935988-5075-1-git-send-email-daniel.vetter@ffwll.ch> <20130704113137.GC8451@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id E8C02E66D1 for ; Thu, 4 Jul 2013 05:41:35 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id e49so740927eek.6 for ; Thu, 04 Jul 2013 05:41:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130704113137.GC8451@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Thu, Jul 04, 2013 at 12:31:37PM +0100, Chris Wilson wrote: > On Thu, Jul 04, 2013 at 01:06:28PM +0200, Daniel Vetter wrote: > > A magic -1 is a obscure, especially since it's actually passed as an > > unsigned, so depens upon the magic sign extension rules in C. This has > > s/depens/depends/. Fixed ... > > > been added in > > > > commit 3727d55e4d85836aa6cb759a965daaef88074150 > > Author: Jesse Barnes > > Date: Wed May 8 10:45:14 2013 -0700 > > > > drm/i915: allow stolen, pre-allocated objects to avoid GTT allocation v2 > > > > Use a proper #define instead. Spotted while reviewing Ben's > > drm_mm_create_block changes. > > > > v2: Cast the constant to u32 since otherwise we again have a type > > mismatch. Suggested by Chris Wilson. > > > > Cc: Ben Widawsky > > Cc: Jesse Barnes > > Signed-off-by: Daniel Vetter > Reviewed-by: Chris Wilson ... and merged, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch