From: Bruce Fields Subject: Re: [RFC] F_SETLEASE mess Date: Mon, 8 Jul 2013 10:17:01 -0400 Message-ID: <20130708141701.GC29071@fieldses.org> References: <20130705090449.GQ4165@ZenIV.linux.org.uk> <1373021495.2216.25.camel@tlielax.poochiereds.net> <1373026124.4269.2.camel@tlielax.poochiereds.net> <20130705162518.GD29747@fieldses.org> <1373060779.2261.11.camel@tlielax.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org, Linus Torvalds To: Jeff Layton Return-path: Received: from fieldses.org ([174.143.236.118]:59123 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430Ab3GHORE (ORCPT ); Mon, 8 Jul 2013 10:17:04 -0400 Content-Disposition: inline In-Reply-To: <1373060779.2261.11.camel@tlielax.poochiereds.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jul 05, 2013 at 05:46:19PM -0400, Jeff Layton wrote: > I think the bigger issue though is that looking at refcounts in order to > determine when we have a conflicting open is just plain wrong. There are > all sorts of reasons one might see a raised refcount that don't involve > conflicting opens (Al's stat() example for instance). It seems like we > ought to shoot for a solution that doesn't rely (solely) on inode and > dentry refcounts. Note that NFSv4 write delegations will need to affect stat as well. (Once you let a client perform writes locally, that client becomes the authority on the attributes, so we have to call back to it on stat.) --b.