Received: from eggs.gnu.org ([2001:4830:134:3::10]:56357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwAow-000594-94 for qemu-devel@nongnu.org; Mon, 08 Jul 2013 08:45:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwAot-00058w-7G for qemu-devel@nongnu.org; Mon, 08 Jul 2013 08:45:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwAos-00058S-T6 for qemu-devel@nongnu.org; Mon, 08 Jul 2013 08:45:31 -0400 Date: Mon, 8 Jul 2013 14:45:27 +0200 From: Igor Mammedov Message-ID: <20130708144527.5d4d280a@nial.usersys.redhat.com> In-Reply-To: <51DAA727.9020506@suse.de> References: <1370438326-27054-1-git-send-email-imammedo@redhat.com> <1370438326-27054-10-git-send-email-imammedo@redhat.com> <51DAA727.9020506@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 09/15] target-i386: move hyperv_* static globals to CPUState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= , Vadim Rozenfeld Cc: Eduardo Habkost , qemu-devel@nongnu.org On Mon, 08 Jul 2013 13:48:55 +0200 Andreas F=E4rber wrote: > Am 05.06.2013 15:18, schrieb Igor Mammedov: > > - since hyperv_* helper functions are used only in target-i386/kvm.c > > move them there as static helpers > >=20 > > Signed-off-by: Igor Mammedov > > Requestd-By: Eduardo Habkost > > --- > > target-i386/Makefile.objs | 2 +- > > target-i386/cpu.c | 16 +++++++--- > > target-i386/cpu.h | 7 +++++ > > target-i386/hyperv.c | 64 -------------------------------------= -------- > > target-i386/hyperv.h | 45 ------------------------------- > > target-i386/kvm.c | 36 ++++++++++++++++++------- > > 6 files changed, 45 insertions(+), 125 deletions(-) > > delete mode 100644 target-i386/hyperv.c > > delete mode 100644 target-i386/hyperv.h >=20 > I proposed a v9 of this that I'd like to queue if you're okay with it: > http://patchwork.ozlabs.org/patch/257454/ I'm ok with it. >=20 > I do wonder if we should transfer Vadim's authorship info somewhere? > It is being deleted along with the target-i386/hyperv.[hc] files. Feel free to add it, if Vadim doesn't object to it. >=20 > Regards, > Andreas >=20 Thanks, Igor