From: Jesse Barnes Subject: Re: [Intel-gfx] [PATCH] drm/i915: correctly restore fences with objects attached Date: Wed, 17 Jul 2013 08:34:48 -0700 Message-ID: <20130717083448.30b8fd5f@jbarnes-desktop> References: <1374065488-4485-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1374065488-4485-1-git-send-email-daniel.vetter@ffwll.ch> Sender: stable-owner@vger.kernel.org To: Daniel Vetter Cc: Intel Graphics Development , "for 3.10 only" List-Id: intel-gfx@lists.freedesktop.org On Wed, 17 Jul 2013 14:51:28 +0200 Daniel Vetter wrote: > + if (reg->obj) { > + i915_gem_object_update_fence(reg->obj, reg, > + reg->obj->tiling_mode); > + } else { > + i915_gem_write_fence(dev, i, NULL); > + } Why do we look at reg->obj here? Can it be NULL? Or would reg->obj->tiling_mode != I915_TILING_NONE do the same thing? -- Jesse Barnes, Intel Open Source Technology Center