From: Chris Wilson Subject: Re: [PATCH] drm/i915: Extend i915_powersave parameter. Date: Wed, 17 Jul 2013 21:13:01 +0100 Message-ID: <20130717201301.GG5249@cantiga.alporthouse.com> References: <1374075372-5648-1-git-send-email-rodrigo.vivi@gmail.com> <20130717154642.GE5249@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 21FA7E6070 for ; Wed, 17 Jul 2013 13:13:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 17, 2013 at 02:45:29PM -0300, Rodrigo Vivi wrote: > So if I understood correctly you suggest that if we have > i915_powersave=0 and i915_enable_rc6=1 we should enable rc6? > This is not how it is implemented nowadays on fbc right now... And > this lead me to use pwoesave as an umbrella for force disable/enable > ignoring individual parameters. But I'm open to do the other way > around as long as we have a standardized behavior. Just depends on whether powersave=0 is default and powersave=-1 is force off, with powersave=1 as force on. > So, we can either respect individual parameters when they are set or > completely ignore. In the way it is now it doesn't respect individual > fbc parameter for powersave=0. My opinion is that we respect the specific module parameters, and if they are left to default values, then apply the global powersave parameter. If that too is default, then we apply the module default. -Chris -- Chris Wilson, Intel Open Source Technology Centre