From: Daniel Kiper Subject: Re: [PATCH v2 4/7] xen: Enforce page size only when xen-syms file is used Date: Fri, 19 Jul 2013 15:44:51 +0200 Message-ID: <20130719134451.GF11233@debian70-amd64.local.net-space.pl> References: <1373977929-4253-1-git-send-email-daniel.kiper@oracle.com> <1373977929-4253-5-git-send-email-daniel.kiper@oracle.com> <20130719182024.7695f88a6e4fe1160a10c74c@mxc.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130719182024.7695f88a6e4fe1160a10c74c-biTfD1RFvDe45+QrQBaojngSJqDPrsil@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Atsushi Kumagai Cc: andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: xen-devel@lists.xenproject.org On Fri, Jul 19, 2013 at 06:20:24PM +0900, Atsushi Kumagai wrote: > On Tue, 16 Jul 2013 14:32:06 +0200 > Daniel Kiper wrote: > > > Enforce page size only when xen-syms file is used. > > Otherwise its size could be read from VMCOREINFO > > file or /proc/vmcore file. > > > > Signed-off-by: Daniel Kiper > > --- > > makedumpfile.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/makedumpfile.c b/makedumpfile.c > > index b42565c..b4abbe5 100644 > > --- a/makedumpfile.c > > +++ b/makedumpfile.c > > @@ -7324,8 +7324,6 @@ initial_xen(void) > > #endif > > if (!init_xen_crash_info()) > > return FALSE; > > - if (!fallback_to_current_page_size()) > > - return FALSE; > > /* > > * Get the debug information for analysis from the vmcoreinfo file > > */ > > @@ -7340,6 +7338,8 @@ initial_xen(void) > > set_dwarf_debuginfo("xen-syms", NULL, > > info->name_xen_syms, info->fd_xen_syms); > > > > + if (!fallback_to_current_page_size()) > > + return FALSE; > > if (!get_symbol_info_xen()) > > return FALSE; > > if (!get_structure_info_xen()) > > This patch has no problem, but I would like to fix a bit for readability. > So could you move the position of fallback_to_current_page_size() to after > this block like initial() ? > > makedumpfile.c::initial() > > 2972 if (!info->page_size) { > 2973 /* > 2974 * If we cannot get page_size from a vmcoreinfo file, > 2975 * fall back to the current kernel page size. > 2976 */ > 2977 if (!fallback_to_current_page_size()) > 2978 return FALSE; > 2979 } Sure. Should I repost whole series or just only this patch? Daniel