From: Chris Wilson Subject: Re: [PATCH 09/12] drm/i915: create vmas at execbuf Date: Mon, 22 Jul 2013 14:32:51 +0100 Message-ID: <20130722133251.GA24082@cantiga.alporthouse.com> References: <1374458899-8635-1-git-send-email-ben@bwidawsk.net> <1374458899-8635-10-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id E054DE664F for ; Mon, 22 Jul 2013 06:33:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1374458899-8635-10-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Sun, Jul 21, 2013 at 07:08:16PM -0700, Ben Widawsky wrote: > @@ -4054,7 +4051,7 @@ void i915_gem_free_object(struct drm_gem_object *gem_obj) > struct i915_vma *i915_gem_vma_create(struct drm_i915_gem_object *obj, > struct i915_address_space *vm) > { > - struct i915_vma *vma = kzalloc(sizeof(*vma), GFP_KERNEL); > + struct i915_vma *vma = kzalloc(sizeof(*vma), GFP_ATOMIC); Hmm, possibly best to erradicate the allocations from underneath the spinlock as the number may be rather large. -Chris -- Chris Wilson, Intel Open Source Technology Centre