From: Ben Widawsky Subject: Re: [PATCH 02/12] drm/i915: Fix up map and fenceable for VMA Date: Tue, 23 Jul 2013 11:14:47 -0700 Message-ID: <20130723181446.GB11802@bwidawsk.net> References: <1374458899-8635-1-git-send-email-ben@bwidawsk.net> <1374458899-8635-3-git-send-email-ben@bwidawsk.net> <20130723164235.GI5939@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 335D4E5D2A for ; Tue, 23 Jul 2013 11:15:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130723164235.GI5939@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 23, 2013 at 06:42:35PM +0200, Daniel Vetter wrote: > On Sun, Jul 21, 2013 at 07:08:09PM -0700, Ben Widawsky wrote: > > formerly: "drm/i915: Create VMAs (part 3.5) - map and fenceable > > tracking" > > > > The map_and_fenceable tracking is per object. GTT mapping, and fences > > only apply to global GTT. As such, object operations which are not > > performed on the global GTT should not effect mappable or fenceable > > characteristics. > > > > Functionally, this commit could very well be squashed in to the previous > > patch which updated object operations to take a VM argument. This > > commit is split out because it's a bit tricky (or at least it was for > > me). > > > > Signed-off-by: Ben Widawsky > > On a quick read there seems to be lots of stuff in here which belongs into > other patches, like error handling changes, debugfs changes. At least > since you claim that the mappable/fenceable stuff is tricky it seems to > not stick out that much ... Yep. I can't remember if I intentionally squashed this, and didn't update the commit, or accidentally squashed it. In either case, you're right. -- Ben Widawsky, Intel Open Source Technology Center