From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h Date: Wed, 24 Jul 2013 18:48:48 +0100 Message-ID: <20130724174848.GA8762@cantiga.alporthouse.com> References: <1374686569-2376-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id E2064E5C2F for ; Wed, 24 Jul 2013 10:48:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1374686569-2376-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 24, 2013 at 10:22:48AM -0700, Jesse Barnes wrote: > For use by userspace (at some point in the future) and other kernel code. Deal. Move it to include/uapi/drm/i915_chipsets.h or i915_pciids.h and we'll start using them. There are too many people with OCD around here to let you get away with not using %04x for the pci-ids. -Chris -- Chris Wilson, Intel Open Source Technology Centre