From: Jesse Barnes Subject: Re: [PATCH] drm/i915: enable IPS for bpp <= 24 Date: Thu, 25 Jul 2013 10:27:22 -0700 Message-ID: <20130725102722.2fc75567@jbarnes-desktop> References: <1374772010-3115-1-git-send-email-jbarnes@virtuousgeek.org> <20130725171759.GF6493@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy5.bluehost.com (oproxy5-pub.bluehost.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id 33BEDE719E for ; Thu, 25 Jul 2013 10:27:18 -0700 (PDT) In-Reply-To: <20130725171759.GF6493@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 25 Jul 2013 18:17:59 +0100 Chris Wilson wrote: > On Thu, Jul 25, 2013 at 10:06:50AM -0700, Jesse Barnes wrote: > > Art confirms that this should work fine. Since most panels are 18bpp > > with dithering from 24bpp, the existing code wouldn't be enabled in most > > cases. > > > > Signed-off-by: Jesse Barnes > > --- > > drivers/gpu/drm/i915/intel_display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index 12ea1a9..7cf475b 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -4091,7 +4091,7 @@ static void hsw_compute_ips_config(struct intel_crtc *crtc, > > { > > pipe_config->ips_enabled = i915_enable_ips && > > hsw_crtc_supports_ips(crtc) && > > - pipe_config->pipe_bpp == 24; > > + pipe_config->pipe_bpp <= 24; > > Don't you want to check that the incoming fb is depth 24? I think this field will have the right bits in it for a 12bpc HDMI config for example, so we should be able to use it for IPS support. -- Jesse Barnes, Intel Open Source Technology Center