From: Mark Brown Subject: Re: [PATCH 4/4] ALSA: oxygen: Updating jack implementation according new ALSA Jacks Date: Fri, 26 Jul 2013 19:56:09 +0100 Message-ID: <20130726185609.GY9858@sirena.org.uk> References: <1374863133-6745-1-git-send-email-eu@felipetonello.com> <1374863133-6745-5-git-send-email-eu@felipetonello.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6042894606620833919==" Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id 1360E2610D3 for ; Fri, 26 Jul 2013 20:56:12 +0200 (CEST) In-Reply-To: <1374863133-6745-5-git-send-email-eu@felipetonello.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Felipe F. Tonello" Cc: alsa-devel@alsa-project.org, Takashi Iwai , Wang Xingchao , linux-kernel@vger.kernel.org, David Henningsson List-Id: alsa-devel@alsa-project.org --===============6042894606620833919== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yeHj6vyFcpxC+65j" Content-Disposition: inline --yeHj6vyFcpxC+65j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 26, 2013 at 11:25:33AM -0700, Felipe F. Tonello wrote: > From: "Felipe F. Tonello" >=20 > ALSA standard jacks already are implemented using ALSA KControl. > So there is no need implement that itself or to use snd_jack > for input events only. Similar changlog comment as on the ASoC patch and... > snd_jack_new(chip->card, "Headphone", > - SND_JACK_HEADPHONE, &data->hp_jack); > + SND_JACK_HEADPHONE, 0, &data->hp_jack); > xonar_ds_handle_hp_jack(chip); =2E..this really ought to be done as part of the commit that adds the parameter since it breaks the build until this patch is applied. --yeHj6vyFcpxC+65j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJR8sZGAAoJELSic+t+oim9vh4P/jlvew18ahVcBJTWRcPFq2Za EtvX0IiAe9IDKAobeV+q4Vf68KJDZ9wTfkaq8QQJHu1gCAmoPK5WtVXOsIuuwGWx NBIc4gF+0+i7AzsWWpu93qN47/1HC15PQoMQxsebR2jSAthaQ89E2yZovYVpPCqe fbuJxsnuDzSjNiWfRGozz23/mNgkTsx5HmsVIkXluW5S4LNV1EqgKrv8m/Zh0NDv lHnzWfYggfDh06XEeDXRmDmaoT0q99S/izpJ2I02lNjkCfkLt/gpzsIQsidzIXBK S4AMWDIlflHHOiL7eBDFquUU2gGnONmrVY+8ViL5bNSQdm5kX8ESYQdUDlPfR6W4 F1dtIbeDtIayFkt1jsa571tTGyt2ztv1npgDOlxeA9nIdeiYvWz3TxBLjkMXj8V7 oBEDDmNQYsgWND8gmn7NK5TMFKEW4oUTU0Pj3fG28rqvTRGZf5yHLIh81lcjxiR3 hUAO/ka2hk8SG7jxFoiAx7aZoONlJWMOVNsSsWtP4CktAhNiFCM9QVLJqN7Mr31n iXGUwAT76R7hYEXYpKJw6l/JGLjH4u5uHDPTRvURo+KBNdvxPFUXQ4oKaWidbGcQ x2b/Xm2i9WPNPRLy14cr5Imc1gdAi3WnqAKksB4xVH4ux9Mw8p99LeBIEwrD5+3/ Fw5yQ55rAMyjqXKqNhug =0QtY -----END PGP SIGNATURE----- --yeHj6vyFcpxC+65j-- --===============6042894606620833919== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6042894606620833919==--