From: Peter Zijlstra Subject: Re: [PATCH] mutex: fix deadlock injection Date: Tue, 30 Jul 2013 10:41:02 +0200 Message-ID: <20130730084102.GI3008@twins.programming.kicks-ass.net> References: <20130701082221.GA14112@gmail.com> <51D3C4C8.8060701@canonical.com> <20130705062345.GA29487@gmail.com> <51F775B5.201@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <51F775B5.201@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Maarten Lankhorst Cc: Ingo Molnar , Linus Torvalds , Linux Kernel Mailing List , Thomas Gleixner , Andrew Morton , Dave Airlie , "dri-devel@lists.freedesktop.org" , Alex Deucher List-Id: dri-devel@lists.freedesktop.org On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: > The check needs to be for > 1, because ctx->acquired is already incremented. > This will prevent ww_mutex_lock_slow from returning -EDEADLK and not locking > the mutex. It caused a lot of false gpu lockups on radeon with > CONFIG_DEBUG_WW_MUTEX_SLOWPATH=y because a function that shouldn't be able > to return -EDEADLK did. > > Cc: Alex Deucher > Signed-off-by: Maarten Lankhorst Thanks!