From: Greg Kroah-Hartman Subject: Re: [PATCH 1/5] Intel MIC Host Driver for X100 family. Date: Wed, 31 Jul 2013 18:44:16 -0700 Message-ID: <20130801014416.GB6941@kroah.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Sudeep Dutt Cc: Peter P Waskiewicz Jr , "Yaozu (Eddie) Dong" , Arnd Bergmann , "Michael S. Tsirkin" , Harshavardhan R Kharche , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ashutosh Dixit , Rob Landley , Caz Yokoyama , Dasaratharaman Chandramouli List-Id: virtualization@lists.linuxfoundation.org On Wed, Jul 24, 2013 at 08:31:32PM -0700, Sudeep Dutt wrote: > This patch enables the following: > a) Initializes the Intel MIC X100 PCIe devices. > b) Boots and shuts down the card via sysfs entries. > c) Allocates and maps a device page for communication with the > card driver and updates the device page address via scratchpad > registers. > d) Provides sysfs entries for family, stepping, state, shutdown > status, kernel command line, IP address, ramdisk and log buffer > information. As you are creating sysfs entries, you also have to create Documentatin/ABI/ entries in the kernel source at the same time. Please do this in your next version of this patch. thanks, greg k-h