From: Christoph Hellwig Subject: Re: [git pull] vfs.git, part 1 Date: Thu, 1 Aug 2013 02:00:46 -0700 Message-ID: <20130801090046.GB21552@infradead.org> References: <20130701195949.GI4165@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Content-Disposition: inline In-Reply-To: <20130701195949.GI4165@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jul 01, 2013 at 08:59:49PM +0100, Al Viro wrote: > The major change in that pile is ->readdir() replacement with ->iterate(), > dealing with ->f_pos races in ->readdir() instances for good. There's > a lot more, but I'd prefer to split the pull request into several stages > and this is the first obvious cutoff point. Please, pull from the > usual place - > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus Again a little later, but iterate seems like a bad choice for a directory specific operation in struct file operations, it really should have "dir" somewhere in the method name.