From: Tom Rini <trini@ti.com>
Date: Fri, 2 Aug 2013 10:45:04 -0400
Subject: [U-Boot] Mac address warning
In-Reply-To: <51FBC3E7.7090506@denx.de>
References: <51FAEF05.1050700@boundarydevices.com> <51FBAF54.1090502@denx.de>
	<20130802141610.GC5164@bill-the-cat> <51FBC3E7.7090506@denx.de>
Message-ID: <20130802144504.GD5164@bill-the-cat>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Aug 02, 2013 at 04:36:23PM +0200, Stefano Babic wrote:
> Hi Tom,
> 
> On 02/08/2013 16:16, Tom Rini wrote:
> >> Well, I have found it very useful in case I set explicitely the
> >> ethaddr variable, so I know where the MAC address comes from. Do
> >> you find it disturbing ? Maybe we could replace "warning" with
> >> "info".
> > 
> > On am335x the message we use is: <ethaddr> not set. Validating
> > first E-fuse MAC And then validate it, and setenv.
> > 
> ..but the code is common as it is located in net/eth.c. The warning
> does not depend on the SOC.

Does it even belong there?  It looks like some generally unused and
dangling functionality, the "write" portion that is.  A number of
drivers do set write_hwaddr, but only usb_ether calls it, and not in an
update the HW fashion...

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130802/14c3b9f3/attachment.pgp>